Project

General

Profile

Actions

Bug #90222

closed

Visual output of slug proposal broken if no slash is prepended

Added by Elias Häußler about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2020-01-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In backend forms, if one generates a slug manually by pressing the "recreate" button next to a slug field, the visual output (label indicating the successful/failed slug proposal) is broken if no slash is defined to be prepended.

To test this, one can easily add a (or use an existing) slug field to a table other than "pages" (as slash prepending is here enabled by default) without defining the prependsSlash configuration in TCA (or setting it explicitly to false). Now, if one recreates the slug in backend form, the visual output should look like this:

slug-currently

For the visual output, we should ensure the proposal is always prepended by a slash in order to make the visual output more clear. It should then look like this (note the slash between "en" and "subpage-1"):

slug-without-enforced-slash

The value itself should not be touched anytime, it's just about visual beauty :)


Files

Bildschirmfoto 2020-01-27 um 21.31.57.png (11.2 KB) Bildschirmfoto 2020-01-27 um 21.31.57.png slug-currently Elias Häußler, 2020-01-27 21:37
Bildschirmfoto 2020-01-27 um 21.32.14.png (11.1 KB) Bildschirmfoto 2020-01-27 um 21.32.14.png slug-without-enforced-slash Elias Häußler, 2020-01-27 21:38
Actions #1

Updated by Elias Häußler about 4 years ago

  • Description updated (diff)
Actions #2

Updated by Gerrit Code Review about 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63051

Actions #3

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63051

Actions #4

Updated by Gerrit Code Review about 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63116

Actions #5

Updated by Gerrit Code Review about 4 years ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63116

Actions #6

Updated by Anonymous about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF