Task #90390

Simplify API in BrokenLinkRepository (linkvalidator) for checking if link target is broken link

Added by Sybille Peters 9 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2020-02-16
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Currently, we return a count in BrokenLinkRepository::getNumberOfBrokenLinks()

This is not necessary, we can just return boolean and rename the function accordingly. This makes the API more readable.

Associated revisions

Revision 41d7cee8 (diff)
Added by Sybille Peters 8 months ago

[TASK] Simplify API for checking link target

Previously, the function BrokenLinkRepository::getNumberOfBrokenLinks()
was used in the event listener. It is not necessary to return the count.
We now only check if the link target is in the list of broken links.

This makes the API easier to read and reduces the number of methods
with similar and misleading names.

Resolves: #90390
Releases: master
Change-Id: Ia94a7a0bd44bbc827864371f7c6694b4b8f8f52a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63267
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Tested-by: Georg Ringer <>
Reviewed-by: Benni Mack <>
Reviewed-by: Georg Ringer <>

History

#1 Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63267

#2 Updated by Sybille Peters 9 months ago

  • Description updated (diff)

#3 Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63267

#4 Updated by Gerrit Code Review 9 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63267

#5 Updated by Gerrit Code Review 9 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63267

#6 Updated by Gerrit Code Review 9 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63267

#7 Updated by Sybille Peters 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF