Project

General

Profile

Actions
Copy link

Feature #90680

closed

Facebook Videos

Added by Robert von Hackwitz over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Could have
Assignee:
-
Category:
Content Rendering
Target version:
Candidate for Major Version
Start date:
2020-03-08
Due date:
% Done:

0%

Estimated time:
PHP Version:
7.2
Tags:
Complexity:
Sprint Focus:

Description

It would be useful to have the possibility to insert facebook videos in addition to those of Youtube and Vimeo.

I developed an extension for my projects (called fal_extra), but wanting to include this functionality in the TYPO3 core these are the changes to make:

- In typo3/sysext/core/Configuration/DefaultConfiguration.php :
 - modify'SYS' => 'mediafile_ext' to
'mediafile_ext' => 'gif,jpg,jpeg,bmp,png,pdf,svg,ai,mp3,wav,mp4,ogg,flac,opus,webm,youtube,vimeo,facebook'
 - add in 'fal' => 'onlineMediaHelpers' 'facebook' => \TYPO3\CMS\Core\Resource\OnlineMedia\Helpers\FacebookHelper::class
 - in 'FileInfo' add 'vimeo' => 'video/facebook',

Then add files attached here to sysext/core/Resource/OnlineMedia/Helpers and sysext/core/Resource/Rendering

Files

Download all files
FacebookHelper.php (4.99 KB) FacebookHelper.php Robert von Hackwitz, 2020-03-08 12:05
FacebookRenderer.php (8.31 KB) FacebookRenderer.php Robert von Hackwitz, 2020-03-08 12:05
Actions
Copy link
 #1

Updated by Robert von Hackwitz over 4 years ago

Robert von Hackwitz wrote:

It would be useful to have the possibility to insert facebook videos in addition to those of Youtube and Vimeo.

I developed an extension for my projects (called fal_extra), but wanting to include this functionality in the TYPO3 core these are the changes to make:
[...]

Then add files attached here to sysext/core/Resource/OnlineMedia/Helpers and sysext/core/Resource/Rendering

FORGOT!
Add to sysext/core/ext_localconf.php "$rendererRegistry->registerRendererClass(\TYPO3\CMS\Core\Resource\Rendering\FacebookRenderer::class);"

AND Correct: in 'FileInfo' add 'facebook' => 'video/facebook',

Actions
Copy link
 #2

Updated by Georg Ringer over 4 years ago

  • Category changed from File Abstraction Layer (FAL) to Content Rendering

Hi,

thanks for creating this issue. I did an extension for stuff like that as well, see https://github.com/georgringer/richmedia.

I am unsure of having all possible providers in the core as this also needs more code to maintain and this is the reason why extensions are there in the 1st place. I would propose that you publish the extenison with a bit better name like "facebook_videos" and close this feature request. would that be ok for you?

Actions
Copy link
 #3

Updated by Georg Ringer over 4 years ago

  • Status changed from New to Needs Feedback
  • Priority changed from Should have to Could have
  • Target version changed from Candidate for patchlevel to Candidate for Major Version
Actions
Copy link
 #4

Updated by Robert von Hackwitz over 4 years ago

Georg Ringer wrote:

Hi,

thanks for creating this issue. I did an extension for stuff like that as well, see https://github.com/georgringer/richmedia.

I am unsure of having all possible providers in the core as this also needs more code to maintain and this is the reason why extensions are there in the 1st place. I would propose that you publish the extenison with a bit better name like "facebook_videos" and close this feature request. would that be ok for you?

I'm really sorry Georg, I haven't noticed about your extension "richmedia".
It's ok for me to close this issue.
Thank you very much!

Actions
Copy link
 #5

Updated by Susanne Moog over 4 years ago

  • Status changed from Needs Feedback to Closed

Thanks for your answer, closing as requested :)

Actions
Copy link

Also available in: Atom PDF