Project

General

Profile

Actions

Bug #90694

closed

Allow external references in AssetRenderer

Added by Frank Nägler about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2020-03-09
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The new AssetCollector and AssetRenderer contains a bug with external source.
The AssetColelctor accept external references like https://foo.com/bar.js but the AssetRenderer kills the URL and creates a broken output.

Example:

$this->assetCollector->addJavaScript('main', 'https://typo3.org/main.js', [
   'type' => 'application/javascript',
   'id' => 'myIdentifier'
]);
<script type="application/javascript" id="myIdentifier" src="/"></script>
Actions #1

Updated by Gerrit Code Review about 4 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63643

Actions #2

Updated by Frank Nägler about 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #3

Updated by Benni Mack about 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF