Task #90695

Streamline SiteLanguage related tests to be based on Site

Added by Oliver Hader 8 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Tests
Target version:
-
Start date:
2020-03-09
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Sprint Focus:

Description

Tests making use of SiteLanguage are adjusted to have a valid parent Site object. This way the implicit aggregate root approach of Site is kept and hanging SiteLanguage instances are avoided.


Related issues

Related to TYPO3 Core - Task #90716: Define SiteLanguage as composite child of SiteInterface Rejected 2020-03-10

Associated revisions

Revision 69e29c0f (diff)
Added by Oliver Hader 7 months ago

[TASK] Streamline SiteLanguage related tests to be based on Site

Tests making use of SiteLanguage are adjusted to have a valid parent
Site object. This way the implicit aggregate root approach of Site
is kept and hanging SiteLanguage instances are avoided.

Resolves: #90695
Releases: master, 9.5
Change-Id: I0d377f511854e3bf9acb364f8b23171007cd847d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63645
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Oliver Hader <>

Revision b537dccd (diff)
Added by Oliver Hader 7 months ago

[TASK] Streamline SiteLanguage related tests to be based on Site

Tests making use of SiteLanguage are adjusted to have a valid parent
Site object. This way the implicit aggregate root approach of Site
is kept and hanging SiteLanguage instances are avoided.

Resolves: #90695
Releases: master, 9.5
Change-Id: I0d377f511854e3bf9acb364f8b23171007cd847d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63648
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63645

#2 Updated by Gerrit Code Review 7 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63648

#3 Updated by Oliver Hader 7 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Oliver Hader 7 months ago

  • Related to Task #90716: Define SiteLanguage as composite child of SiteInterface added

#5 Updated by Benni Mack 6 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF