Project

General

Profile

Actions

Bug #90762

closed

Linkvalidator "Check this level / Show this level" dropdown contains identical labels

Added by Riccardo De Contardi over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2020-03-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.2
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

Environment

TYPO3 10.4.0-dev (latest master)

Steps to reproduce

1) Go to Linkvalidator > Tab "Reports" and open the dropdown "Show this level"

or

2) Go to Linkvalidator > Tab "Check links" and open the dropdown "Check this level"

Results:

See attached file:

Expected results

Different labels should be used

The problem lies on the file /typo3/sysext/linkvalidator/Resources/Private/Layouts/TabContent.html that uses the same label LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.depth_0 for different <option>

        <select name="{prefix}_search_levels" class="form-control">
            <option value="0"{f:if(condition: '{selectedLevel} == 0', then: 'selected')}><f:translate key="LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.depth_0" /></option>
            <option value="1"{f:if(condition: '{selectedLevel} == 1', then: 'selected')}><f:translate key="LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.depth_0" /></option>
            <option value="2"{f:if(condition: '{selectedLevel} == 2', then: 'selected')}><f:translate key="LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.depth_0" /></option>
            <option value="3"{f:if(condition: '{selectedLevel} == 3', then: 'selected')}><f:translate key="LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.depth_0" /></option>
            <option value="4"{f:if(condition: '{selectedLevel} == 4', then: 'selected')}><f:translate key="LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.depth_0" /></option>
            <option value="999"{f:if(condition: '{selectedLevel} == 999', then: 'selected')}><f:translate key="LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.depth_infi" /></option>
        </select>

Files

cattura3.png (182 KB) cattura3.png Riccardo De Contardi, 2020-03-14 16:36
Actions #1

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63723

Actions #2

Updated by Riccardo De Contardi over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #3

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF