Bug #90820: CSS/JS compression problem if css is used inline - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #90820

closed

CSS/JS compression problem if css is used inline

Added by Timo Poppinga over 4 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Frontend

Target version:

Start date:

2020-03-23

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

TypoScript: config.compressCss = 1

Install Tool [FE][compressionLevel] > 0

and css is inline, it will be compressed and add as binary in the html this does not work.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Susanne Moog over 4 years ago

Status changed from New to Needs Feedback

Tried with the following TypoScript:

config.compressCss = 1
page.cssInline {
    10 = TEXT
    10.value = body {background:lime;}

    20 = TEXT
    20.value = h1 {color: blue;}
}

This creates an external file with .gzip and that content, because of inlineStyleToTempFile. Next I tested with:

config.inlineStyle2TempFile = 0
config.compressCss = 1
page.cssInline {
    10 = TEXT
    10.value = body {background:lime;}

    20 = TEXT
    20.value = h1 span {color: blue;}
}

which results in:

<style type="text/css">
/*<![CDATA[*/
<!-- 
/*additionalTSFEInlineStyle*/
body {background:lime;}h1 span {color: blue;}
-->
/*]]>*/
</style>

which looks fine to me.

How to reproduce your issue? How do you add your inline CSS?

Actions

Copy link

Updated by Timo Poppinga over 4 years ago

hi i did link this:

page {
    includeCSSLibs {
        main = EXT:xxxxx/Resources/Public/StyleSheets/main.css
        main {
            inline = 1
        }
    }
}

config {
    concatenateJs = 1
    compressJs= 1

    concatenateCss = 1
    compressCss = 1
}

and

[FE][compressionLevel] = 9

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63884

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63865

Actions

Copy link