Task #90831

Provide tests for Page\TreeController

Added by Tymoteusz Motylewski 7 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Should have
Category:
Pagetree
Start date:
2020-03-25
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

In order to be able to do performance optimizations and refactorings, the Page\TreeController should be covered with test.

Associated revisions

Revision d1370d2c (diff)
Added by Tymoteusz Motylewski 6 months ago

[TASK] Provide test for Page\TreeController

Add test for TreeController, so we're safe when refactoring
or doing performance optimizations.

Besides that moved pages in a workspace were not considered when
calculating permissions on the rootline due to missing workspace
overlays.

Resolves: #90831
Releases: 9.5, master
Change-Id: Ic3ab08d2502e8c9a3f08e737552c2e1d2a56a66c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Oliver Hader <>

Revision 98d21328 (diff)
Added by Tymoteusz Motylewski 6 months ago

[TASK] Provide test for Page\TreeController

Add test for TreeController, so we're safe when refactoring
or doing performance optimizations.

Besides that moved pages in a workspace were not considered when
calculating permissions on the rootline due to missing workspace
overlays.

Resolves: #90831
Releases: 9.5, master
Change-Id: Ic3ab08d2502e8c9a3f08e737552c2e1d2a56a66c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64107
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Tested-by: Georg Ringer <>
Tested-by: Tymoteusz Motylewski <>
Reviewed-by: Oliver Hader <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Tymoteusz Motylewski <>

History

#1 Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#2 Updated by Gerrit Code Review 7 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#3 Updated by Gerrit Code Review 7 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#4 Updated by Gerrit Code Review 7 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#5 Updated by Gerrit Code Review 7 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#6 Updated by Gerrit Code Review 7 months ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#7 Updated by Gerrit Code Review 7 months ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#8 Updated by Gerrit Code Review 7 months ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#9 Updated by Gerrit Code Review 7 months ago

Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#10 Updated by Gerrit Code Review 7 months ago

Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#11 Updated by Gerrit Code Review 7 months ago

Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#12 Updated by Gerrit Code Review 7 months ago

Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#13 Updated by Gerrit Code Review 7 months ago

Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#14 Updated by Gerrit Code Review 7 months ago

Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#15 Updated by Gerrit Code Review 7 months ago

Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#16 Updated by Gerrit Code Review 7 months ago

Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#17 Updated by Gerrit Code Review 7 months ago

Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#18 Updated by Gerrit Code Review 7 months ago

Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#19 Updated by Gerrit Code Review 6 months ago

Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848

#20 Updated by Gerrit Code Review 6 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64107

#21 Updated by Tymoteusz Motylewski 6 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#22 Updated by Benni Mack 6 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF