Task #90839

Epic #90812: Fluid-based Page Module

Streamline BackendLayout API class

Added by Benni Mack 13 days ago. Updated 10 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
Backend API
Target version:
Start date:
2020-03-26
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Task #90943: Warning in unit tests due to BackendLayout::parseConfigurationStringAndSetConfigurationArray being removed Resolved 2020-04-04

Associated revisions

Revision 0e464ae4 (diff)
Added by Benni Mack 13 days ago

[TASK] Streamline BackendLayout API class

This change moves the ConditionMatching back to the BackendLayoutView.

The main goal is to make BackendLayout more of an entity class again,
whereas BackendLayoutView should be the process to build the BackendLayout
objects, and configuration and return them, and act more as a
BackendLayoutResolver - this could / should be renamed in the future.

This change thus reactivates runtime-caching for fetching
a backend layout configuration again.

In addition, the new method "getBackendLayoutForPage()" now
actually returns a "ready-to-use" Backend Layout instance,
which could also used for the Nested Content Grid in the future.

The previous "configurationArray" is now defined as "stucture".

A short-hand function "getUsedColumns()" is added.

Resolves: #90839
Releases: master
Change-Id: Ic6e65317a5faa6d70a181fc3f24b3716a1137c39
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63918
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Tested-by: Frank Nägler <>
Tested-by: Benni Mack <>
Reviewed-by: Georg Ringer <>
Reviewed-by: Frank Nägler <>
Reviewed-by: Benni Mack <>

Revision 32062db4 (diff)
Added by Claus Due 10 days ago

[TASK] Streamline BackendLayout API class

Followup with minor corrections for https://review.typo3.org/c/Packages/TYPO3.CMS/+/63918

  • Relaxes method signature of getSelectedBackendLayout
    to restore compatibilty with third party XCLASS.
  • Avoids parsing empty configuration strings (in use
    cases where configuration is passed to BackendLayout
    as array, not TS string).
  • Uses DrawingConfiguration instance provided from
    BackendLayout instead of creating a new instance to
    override the one returned from BackendLayout.
  • Fixes a method call with unused return value.

Releases: master
Resolves: #90839
Change-Id: If6fe1286d3ce6530de30ea4c534ac1799e63177e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63968
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

Revision 3a65496e (diff)
Added by Anja Leichsenring 3 days ago

[TASK] Remove warning from BackendLayout UnitTest after method removal

During refactoring of the class a method was removed, that was still
mentioned in a mock creation. This raised a warning in unit test runs.
Removing the mentioning (and the mock alongside with it) returns
the tests to green.

Resolves: #90943
Related: #90348
Related: #90839
Releases: master
Change-Id: I558d0bcd31942aac6241c819c8bf011dba23fe2c
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64067
Reviewed-by: Claus Due <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Guido Schmechel <>
Reviewed-by: Alexander Schnitzler <>
Reviewed-by: Andreas Fernandez <>
Tested-by: TYPO3com <>
Tested-by: Alexander Schnitzler <>
Tested-by: Andreas Fernandez <>

History

#1 Updated by Gerrit Code Review 13 days ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63918

#2 Updated by Gerrit Code Review 13 days ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63918

#3 Updated by Gerrit Code Review 13 days ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63918

#4 Updated by Benni Mack 12 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Gerrit Code Review 11 days ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63968

#6 Updated by Gerrit Code Review 11 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63968

#7 Updated by Gerrit Code Review 11 days ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63968

#8 Updated by Anonymous 10 days ago

  • Status changed from Under Review to Resolved

#9 Updated by Anja Leichsenring 4 days ago

  • Related to Task #90943: Warning in unit tests due to BackendLayout::parseConfigurationStringAndSetConfigurationArray being removed added

Also available in: Atom PDF