Project

General

Profile

Actions

Bug #90952

closed

Link Browser in ckeditor breaks with browser search

Added by Andreas Kienast over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
-
Start date:
2020-04-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The Link Browser used with ckeditor breaks when selecting e.g. a file when the browser search is used to find a record in the Link Browser.

How to reproduce (tested in Chrome):

  • Select a text in ckeditor
  • Open link browser by clicking the "Link" icon
  • Switch to tab "File"
  • Open browser search (CTRL + F, for example)
  • Search for anything that matches a file
  • Click that file

The browser console of Chrome now logs the error Uncaught TypeError: Cannot read property 'getParent' of null.

In Firefox, the whole text gets linked instead.

The issue is that the browser search creates a new Selection which overrides the previous selection done by the editor.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #91006: ckeditor still loses ranges when using browser search in RTELinkBrowserClosed2020-04-12

Actions
Related to TYPO3 Core - Bug #84299: CKEditor IE 11 link update copies the current link to the beginningClosed2018-03-15

Actions
Actions #1

Updated by Gerrit Code Review over 4 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64078

Actions #2

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64078

Actions #3

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64078

Actions #4

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63985

Actions #5

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63985

Actions #6

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63985

Actions #7

Updated by Andreas Fernandez over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Gerrit Code Review over 4 years ago

  • Status changed from Resolved to Under Review

Patch set 4 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63985

Actions #9

Updated by Andreas Fernandez over 4 years ago

  • Status changed from Under Review to Resolved
Actions #10

Updated by Andreas Kienast over 4 years ago

  • Related to Bug #91006: ckeditor still loses ranges when using browser search in RTELinkBrowser added
Actions #11

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions #12

Updated by Benni Mack over 4 years ago

  • Related to Bug #84299: CKEditor IE 11 link update copies the current link to the beginning added
Actions

Also available in: Atom PDF