Task #90984
closedAdd `phpstan analyse` to Build/Scripts/runTests.sh
0%
Description
command from Build/bamboo/src/main/java/core/AbstractCoreSpec.java
" docker run \\\n" + " -u ${HOST_UID} \\\n" + " -v /bamboo-data/${BAMBOO_COMPOSE_PROJECT_NAME}/passwd:/etc/passwd \\\n" + " -v ${BAMBOO_COMPOSE_PROJECT_NAME}_bamboo-data:/srv/bamboo/xml-data/build-dir/ \\\n" + " --name ${BAMBOO_COMPOSE_PROJECT_NAME}sib_adhoc \\\n" + " --rm \\\n" + " typo3gmbh/" + requirementIdentifier.toLowerCase() + ":latest \\\n" + " bin/bash -c \"cd ${PWD}; ./bin/phpstan analyse --no-progress --no-interaction $*\"\n" +
It is using the same image as the other tests.
There should be no reason not to have it in our official local test runner script.
Updated by Benni Mack over 4 years ago
Please specify what you want to do, Jonas, and the reason behind it.
Updated by Jonas Eberle over 4 years ago
I am suggesting to add a `phpstan` command to our local test runner environment `runTests.sh`.
The reasoning is that `phpstan` is run in the bamboo tests and in my opinion it should be possible to run CI-checks locally, too.
In this case it is very easy to accomplish, too.
Updated by Benni Mack over 4 years ago
Yes, I see that this would be easy to accomplish, but this would mean that our test runs would be much slower, right?
Updated by Jonas Eberle over 4 years ago
Benni Mack wrote:
but this would mean that our test runs would be much slower, right?
It would be a separate subcommand (./Build/runTests.sh phpstan ...) and would not affect other tests run locally or even the bamboo tests.
Updated by Benni Mack over 4 years ago
- Status changed from New to Accepted
Let's assume I would accept this issue...
Updated by Benni Mack over 3 years ago
- Related to Task #93367: runTests.sh: Add phpstan and docBlockCheck added
Updated by Benni Mack over 3 years ago
- Status changed from Accepted to Closed