Task #91059

Disable rector auto_import_names for ServiceProviders

Added by Benjamin Franzke 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
Start date:
2020-04-16
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The changes applied in https://review.typo3.org/c/Packages/TYPO3.CMS/+/64180/8/typo3/sysext/extbase/Classes/ServiceProvider.php cause the getFactories array to appear quite randomly, while it was grouped using relative paths before.

Before, grouped:

            Object\Container\Container::class => [ static::class, 'getObjectContainer' ],
            Object\ObjectManager::class => [ static::class, 'getObjectManager' ],
            SignalSlot\Dispatcher::class => [ static::class, 'getSignalSlotDispatcher' ],
            Configuration\ConfigurationManager::class => [ static::class, 'getConfigurationManager' ],
            Reflection\ReflectionService::class => [ static::class, 'getReflectionService' ],
            Service\EnvironmentService::class => [ static::class, 'getEnvironmentService' ],
            Service\ExtensionService::class => [ static::class, 'getExtensionService' ],
            Security\Cryptography\HashService::class => [ static::class, 'getHashService' ],
        ];
    }

After, without grouping:

            Container::class => [ static::class, 'getObjectContainer' ],
            ObjectManager::class => [ static::class, 'getObjectManager' ],
            Dispatcher::class => [ static::class, 'getSignalSlotDispatcher' ],
            ConfigurationManager::class => [ static::class, 'getConfigurationManager' ],
            ReflectionService::class => [ static::class, 'getReflectionService' ],
            EnvironmentService::class => [ static::class, 'getEnvironmentService' ],
            ExtensionService::class => [ static::class, 'getExtensionService' ],
            HashService::class => [ static::class, 'getHashService' ],

Associated revisions

Revision cbe2ccc9 (diff)
Added by Benjamin Franzke 3 months ago

[TASK] Disable rector for ServiceProviders to avoid auto_import_names

rectors `auto_import_names` causes relative class names to
be transformed into `use` statements.
This reduces the readability of the grouped
getFactories array as used in ServiceProviders, we rather used
to define all external dependencies in use statements and
to include local dependencies using relative class names.

Also revert the change in TYPO3\CMS\Extbase\ServiceProvider
which has already been applied in #91047 using:
git checkout 682873dd61ccd398bcf58b1e76133b638cf5ecf9^ -- \
typo3/sysext/extbase/Classes/ServiceProvider.php

Releases: master
Resolves: #91059
Related: #91047
Change-Id: I16c4b0d264b2acc5149da375967d862c879f2958
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64198
Tested-by: TYPO3com <>
Tested-by: Alexander Schnitzler <>
Reviewed-by: Alexander Schnitzler <>

Revision 31bae041 (diff)
Added by Andreas Fernandez 2 months ago

[BUGFIX] Resolve merge conflict in NightlySpec

Resolves: #91209
Related: #91059
Releases: 9.5
Change-Id: Ib42fb2f5bfdf2b4e10a53cedaca280e4164e6965
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64324
Tested-by: Andreas Fernandez <>
Tested-by: Anja Leichsenring <>
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64198

#2 Updated by Gerrit Code Review 3 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64198

#3 Updated by Gerrit Code Review 3 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64198

#4 Updated by Benjamin Franzke 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF