Task #91059

Disable rector auto_import_names for ServiceProviders

Added by Benjamin Franzke about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
Start date:
2020-04-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The changes applied in https://review.typo3.org/c/Packages/TYPO3.CMS/+/64180/8/typo3/sysext/extbase/Classes/ServiceProvider.php cause the getFactories array to appear quite randomly, while it was grouped using relative paths before.

Before, grouped:

            Object\Container\Container::class => [ static::class, 'getObjectContainer' ],
            Object\ObjectManager::class => [ static::class, 'getObjectManager' ],
            SignalSlot\Dispatcher::class => [ static::class, 'getSignalSlotDispatcher' ],
            Configuration\ConfigurationManager::class => [ static::class, 'getConfigurationManager' ],
            Reflection\ReflectionService::class => [ static::class, 'getReflectionService' ],
            Service\EnvironmentService::class => [ static::class, 'getEnvironmentService' ],
            Service\ExtensionService::class => [ static::class, 'getExtensionService' ],
            Security\Cryptography\HashService::class => [ static::class, 'getHashService' ],
        ];
    }

After, without grouping:

            Container::class => [ static::class, 'getObjectContainer' ],
            ObjectManager::class => [ static::class, 'getObjectManager' ],
            Dispatcher::class => [ static::class, 'getSignalSlotDispatcher' ],
            ConfigurationManager::class => [ static::class, 'getConfigurationManager' ],
            ReflectionService::class => [ static::class, 'getReflectionService' ],
            EnvironmentService::class => [ static::class, 'getEnvironmentService' ],
            ExtensionService::class => [ static::class, 'getExtensionService' ],
            HashService::class => [ static::class, 'getHashService' ],
#1

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64198

#2

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64198

#3

Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64198

#4

Updated by Benjamin Franzke about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#5

Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF