Project

General

Profile

Actions

Bug #91127

closed

"Starting module" is never resolved from first available module

Added by Claus Due over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2020-04-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When UC is empty, the first available module is not detected since \TYPO3\CMS\Backend\Controller\BackendController::determineFirstAvailableBackendModule is never called. This is because $beUser->uc['startModule'] is always filled but does not get filled with the first available module from the list - rather, it gets filled with the last available module.

Note that EXT:dashboard must be uninstalled since this extension forces itself to be the default starting module and therefore hides the misbehavior.

Actions #1

Updated by Claus Due over 4 years ago

Stems from \TYPO3\CMS\Core\Authentication\BackendUserAuthentication::$uc_default being used instead of resolving the first available module, when UC is empty.

Actions #2

Updated by Claus Due over 4 years ago

Seems it actually does execute the function you added, but: 1) it only does if the UC field in DB is explicitly NULL instead of just empty, 2) at some point, likely before your patch, something changed the startModule setting in my UC to help_AboutAbout without any interaction. I would suggest that we make the default value of \TYPO3\CMS\Core\Authentication\BackendUserAuthentication::$uc_default[‘startModule’] an empty string, especially since help_AboutAbout comes from an extension that is optional. As far as I could determine, this solves the issue (and also catches the case of DB field being empty but not explicitly NULL).

Actions #3

Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64247

Actions #4

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64247

Actions #5

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64247

Actions #6

Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64247

Actions #7

Updated by Gerrit Code Review over 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64247

Actions #8

Updated by Andreas Fernandez over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF