Bug #91205: Backend content iFrame breaks with setting [BE][cookieSameSite]="lax" because ContextHelp.js uses "use strict" - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #91205

closed

Backend content iFrame breaks with setting [BE][cookieSameSite]="lax" because ContextHelp.js uses "use strict"

Added by Nitin Parri over 4 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Backend JavaScript

Target version:

next-patchlevel

Start date:

2020-04-27

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

7.4

Tags:

samesite, cookieSameSite, ContextHelp, use strict

Complexity:

Is Regression:

Sprint Focus:

Description

If you use any SSO method with [BE][cookieSameSite]="lax", the backend will give an error:

Blocked a frame with origin "https://domain.tld" from accessing a cross-origin frame.

It's because file /typo3/sysext/backend/Resources/Public/JavaScript/ContextHelp.js uses "use strict".

Solution:
ContextHelp.js must take over the value of setting [BE][cookieSameSite]

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Andreas Kienast over 4 years ago

Status changed from New to Needs Feedback

Can you please elaborate on why use strict causes this behavior? use strict enables JavaScript's strict mode regarding error handling and code execution, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Strict_mode.

Actions

Copy link

Updated by Andreas Kienast over 4 years ago

Related to Bug #91270: ContextHelp.js: Uncaught DOMException: Blocked a frame with origin "http://localhost" from accessing a cross-origin frame. added

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Status changed from Needs Feedback to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64394

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64394

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64394

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64404

Actions

Copy link

Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64404

Actions

Copy link