Task #91229

Use proper TypeScript functions instead of arrow functions

Added by Oliver Hader 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend JavaScript
Target version:
-
Start date:
2020-04-28
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Currently arrow functions (like delta functions or closure functions) are assigned to class properties.

public handleSubmit = (event: Event): void => { }

which could be simplified as real functions

public handleSubmit(event: Event): void { }

In PHP the original scenario would look like

class Thing
{
  public $handleSubmit;

  public function __construct()
  {
    $this->handleSubmit = function($event) {}
  }
}

Associated revisions

Revision 07280a4f (diff)
Added by Oliver Hader 2 months ago

[TASK] Use proper TypeScript functions instead of arrow functions

Resolves: #91229
Releases: master, 9.5
Change-Id: Ieb6211252a74983a89b7a1057574a1ebe29ae390
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64341
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Markus Klein <>
Reviewed-by: Benni Mack <>
Reviewed-by: Oliver Hader <>

Revision dd8cf23a (diff)
Added by Oliver Hader 2 months ago

[TASK] Use proper TypeScript functions instead of arrow functions

Resolves: #91229
Releases: master, 9.5
Change-Id: Ieb6211252a74983a89b7a1057574a1ebe29ae390
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64349
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64341

#2 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64341

#3 Updated by Oliver Hader 2 months ago

  • Description updated (diff)

#4 Updated by Oliver Hader 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF