Project

General

Profile

Actions
Copy link

Task #91231

closed

Add tags to clearCachePostProc Hook parameters

Added by Patrick Schriner almost 4 years ago. Updated 14 days ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
DataHandler aka TCEmain
Target version:
-
Start date:
2020-04-29
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:

Description

Tags are not passed to the clearCachePostProc hooks which means any implementation will have to duplicate the same logic.

Actions
Copy link
 #1

Updated by Gerrit Code Review almost 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64344

Actions
Copy link
 #2

Updated by Gerrit Code Review almost 4 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64353

Actions
Copy link
 #3

Updated by Patrick Schriner almost 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Benni Mack almost 4 years ago

  • Status changed from Resolved to Closed
Actions
Copy link
 #5

Updated by Philipp Kitzberger 14 days ago ยท Edited

Unfortunately the "tags" array looks different for the two cases the clearCachePostProc is being called:

  • DataHandler->clear_cacheCmd(): "tags" is an array with numeric indices and the cache tag as value
  • DataHandler->prepareCacheFlush(): "tags" is an array with cache tags as indices and true as value

So handling those tags in a hook needs to take those two "formats" into consideration, which I find not ideal ;-(

(TYPO3 11)

Actions
Copy link

Also available in: Atom PDF