Bug #91260

\TYPO3\CMS\Core\Configuration\SiteConfiguration cannot be overridden with XCLASS

Added by Helmut Hummel 9 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2020-05-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

With #89892 SiteConfiguration was configured in a ServiceProvider,
which makes it available in the failsafe and Symfony container.

However the object is created using, instead of using self::new
which would respect XCLASS definition


Related issues

Related to TYPO3 Core - Task #89892: Define singletons used in install tool in service providersClosed2019-12-06

Actions
#1

Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64386

#2

Updated by Helmut Hummel 9 months ago

  • Related to Task #89892: Define singletons used in install tool in service providers added
#3

Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64386

#4

Updated by Gerrit Code Review 9 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64386

#5

Updated by Helmut Hummel 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF