Task #91363

GeneralUtility::getContainer is @internal and should therefore be avoided in functional tests

Added by Benjamin Franzke about 2 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Should have
Category:
Tests
Start date:
2020-05-11
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Associated revisions

Revision 3c7867fc (diff)
Added by Benjamin Franzke about 2 months ago

[TASK] Don't use GeneralUtility::getContainer in functional tests

As GeneralUtility::getContainer is marked internal, we do now avoid
to use this method in core tests in order to demonstrate best
practices for third party extensions that may use core tests as
inspiration.

This change requires an update for typo3/testing-framework which now
provides a getContainer() method as API in functional tests:

composer require --dev typo3/testing-framework:^6.2.5

Releases: master
Resolves: #91363
Change-Id: I844973ddd3355d15c72307ac9533429333a396da
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64456
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Benni Mack <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64456

#2 Updated by Gerrit Code Review about 2 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64456

#3 Updated by Benjamin Franzke about 2 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF