Bug #91438

SiteAccessorTrait is too strict, when resolved record is not part of a site

Added by Helmut Hummel 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2020-05-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When saving a reocrd on a page that is not part of a site, the slug field of this record,
despite being set to "uniqueInSite" is not checked for uniqueness, as it is assumed unique enough.

The SiteAccessorTrait in contrast to that, declares such record not part of the current site.

Both parts though must always behave the same and make the same assumptions.

In the future, we should throw a warning or at least a notice for such case. Records with slugs defined as "uniqueInSite"
must never be stored outside a site. It does not make any sense to do so.
Instead configuration needs to be adapted to either "unique" or even empty, whatever fits the use case.


Related issues

Related to TYPO3 Core - Bug #91235: News Detail Page 404 after upgrade 9.5.16Closed2020-04-29

Actions
#1

Updated by Helmut Hummel 8 months ago

  • Related to Bug #91235: News Detail Page 404 after upgrade 9.5.16 added
#2

Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64520

#3

Updated by Gerrit Code Review 8 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64520

#4

Updated by Gerrit Code Review 8 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64520

#5

Updated by Gerrit Code Review 8 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64520

#6

Updated by Gerrit Code Review 8 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64525

#7

Updated by Helmut Hummel 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#8

Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF