Task #91548

Switch to json_encode for file folder tree

Added by Oliver Hader about 1 month ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Should have
Assignee:
Category:
Security
Target version:
-
Start date:
2020-05-31
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
hardening
Complexity:
Sprint Focus:

Description

Scalar values sent via HTTP query parameters to FileSystemNavigationFrameController
are using `json_encode` instead of `unserialize`. The parameter
stream is still secured with an HMAC before being deserialized.

Associated revisions

Revision d46a06b5 (diff)
Added by Oliver Hader about 1 month ago

[TASK] Switch to json_encode for file folder tree

Scalar values sent via HTTP query parameters to
FileSystemNavigationFrameController are using `json_encode` instead
of `unserialize`. The parameter stream is still secured with an HMAC
before being deserialized.

Resolves: #91548
Releases: master, 10.4, 9.5
Change-Id: I57be68aac1787bdc27f2bbae40f8d71b1b33f79f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64624
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Tested-by: Frank Nägler <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Anja Leichsenring <>
Reviewed-by: Frank Nägler <>
Reviewed-by: Andreas Fernandez <>

Revision 237f4950 (diff)
Added by Oliver Hader about 1 month ago

[TASK] Switch to json_encode for file folder tree

Scalar values sent via HTTP query parameters to
FileSystemNavigationFrameController are using `json_encode` instead
of `unserialize`. The parameter stream is still secured with an HMAC
before being deserialized.

Resolves: #91548
Releases: master, 10.4, 9.5
Change-Id: I57be68aac1787bdc27f2bbae40f8d71b1b33f79f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64625
Tested-by: Andreas Fernandez <>
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>

Revision 583fe026 (diff)
Added by Oliver Hader about 1 month ago

[TASK] Switch to json_encode for file folder tree

Scalar values sent via HTTP query parameters to
FileSystemNavigationFrameController are using `json_encode` instead
of `unserialize`. The parameter stream is still secured with an HMAC
before being deserialized.

Resolves: #91548
Releases: master, 10.4, 9.5
Change-Id: I57be68aac1787bdc27f2bbae40f8d71b1b33f79f
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64626
Tested-by: TYPO3com <>
Tested-by: Andreas Fernandez <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Andreas Fernandez <>

History

#1 Updated by Gerrit Code Review about 1 month ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64624

#2 Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64625

#3 Updated by Gerrit Code Review about 1 month ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64626

#4 Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64625

#5 Updated by Oliver Hader about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF