Project

General

Profile

Actions

Bug #91585

closed

JavaScript-Error breaks Flexform IRRE elements

Added by Jonas Temmen almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend JavaScript
Target version:
-
Start date:
2020-06-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.4
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When editing a flexform that has an IRRE-ELement in it a JavaScript-Error occurs on opening (toggling) the IRRE Element

TypeError: e is null

This error breaks the functionality of textfields (type = "input") within the IRRE Element. These don't have the "x" for deleting the content in it, nor is the content saved to DB.

After a short debugging I found out it is related to https://forge.typo3.org/issues/91183

The ID of an element contained a "." (dot) from the concatination of various information including the name of the field in the flexform (settings.whatsoever). This throws the error in "nprogress.js" as there is a call to "document.queryselector" which cannot handle IDs with dots as this will be interpreted as "has id AND className".

Since "nprogress.js" is a third-party-library I think it can't be fixed there.

As dots in the ID of a HTML-element is generally not a good idea, maybe these could be stripped completly as the form is built?

If necessary I can provide more information on this, feel free to contact me.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #91183: FAL inline field in FlexForms does not add fileClosed2020-04-23

Actions
Actions #1

Updated by Jonas Temmen almost 4 years ago

  • Subject changed from JS Error Breaks Flexform IRRE Elements to JavaScript-Error breaks Flexform IRRE elements
Actions #2

Updated by Gerrit Code Review almost 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64783

Actions #3

Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64783

Actions #4

Updated by Gerrit Code Review almost 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64783

Actions #5

Updated by Gerrit Code Review almost 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64783

Actions #6

Updated by Gerrit Code Review almost 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64783

Actions #7

Updated by Gerrit Code Review almost 4 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64783

Actions #8

Updated by Gerrit Code Review almost 4 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64783

Actions #9

Updated by Anja Leichsenring almost 4 years ago

  • Related to Bug #91183: FAL inline field in FlexForms does not add file added
Actions #10

Updated by Gerrit Code Review almost 4 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64918

Actions #11

Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64918

Actions #12

Updated by Andreas Fernandez almost 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF