Bug #91812

Loading order of css / js changed in viewhelper be.container

Added by Marcus Schwemer almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Fluid
Target version:
-
Start date:
2020-07-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

In commit #de6af8b1c186b05fcb69fad653dc869041 the document template was replaced with the module template. (https://github.com/TYPO3/TYPO3.CMS/commit/de6af8b1c186b05fcb69fad653dc86904101d444#diff-1d392567ef98b9430951be82a00fcca8)

This change also led to a change in the loading order of the css files. Prior to this change the custom css files were loaded after the default files from core. Now they are loaded before the core css files.

Reason:

The document template added the core css files in the constructor. Afterwards the custom css files were added. Now the core css files are add in the last method call $moduleTemplate->renderContent() (EXT:fluid/Classes/ViewHelpers/Be/ContainerViewHelper.php).

Impact:

If you are overriding core css classes, these changes are not taken into account any more.

#1

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65236

#2

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65236

#3

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65423

#4

Updated by Benni Mack over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#5

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF