Project

General

Profile

Actions
Copy link

Bug #91833

closed

When form option has label equals to 0 (zero), it's replaced by the empty string

Added by Jiří Štefl almost 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2020-07-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:
Remote Sprint

Description

Steps to reproduce:

  1. Create a new form in the backend wizard.
  2. Create a radio button element (eg Number of children) in this form with options: 0, 1, 2, 3 (same label & value).

Current result:

In the frontend the first option has an empty string as the label.

Expected result:

The first option has '0' as the label.

Problem:

There are "empty variable" conditions in TYPO3\CMS\Form\Service\TranslationService->translateFormElementValue() on lines 364 & 368. This will be true if the string is empty or equal to '0' (https://www.php.net/manual/en/function.empty.php).

Solution:

Change conditions to: 

(empty($defaultValue) && $defaultValue !== '0')

Actions
Copy link
 #1

Updated by Björn Jacob over 2 years ago

  • Sprint Focus set to Remote Sprint
Actions
Copy link
 #2

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74992

Actions
Copy link
 #3

Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74992

Actions
Copy link
 #4

Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74992

Actions
Copy link
 #5

Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74992

Actions
Copy link
 #6

Updated by Gerrit Code Review almost 2 years ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74992

Actions
Copy link
 #7

Updated by Gerrit Code Review almost 2 years ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74992

Actions
Copy link
 #8

Updated by Gerrit Code Review almost 2 years ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74992

Actions
Copy link
 #9

Updated by Gerrit Code Review almost 2 years ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74992

Actions
Copy link
 #10

Updated by Gerrit Code Review almost 2 years ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74992

Actions
Copy link
 #11

Updated by Anonymous almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #12

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF