Project

General

Profile

Actions
Copy link

Feature #91890

closed

Make the list in the redirects module sortable

Added by Stefan P over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2020-07-29
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

It would be nice if one could sort the redirects in teh module, especially by hit count and last hit (for example to easily find "dead" redirects that can be deleted).

Files

redirects-ordering.patch (6.62 KB) redirects-ordering.patch Patch file for TYPO3 9.5.20 Benjamin Serfhos, 2020-08-14 14:37
Actions
Copy link
 #1

Updated by Stefan P over 3 years ago

It is possible to achive this slightly in the list module on the root (0), but without the nice interface and the filtering. But this can only be done by admins, not by editors, anyways.

Actions
Copy link
 #2

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

Actions
Copy link
 #3

Updated by Stefan P over 3 years ago

Any chance that gets ported back to v9?

Actions
Copy link
 #4

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

Actions
Copy link
 #5

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

Actions
Copy link
 #6

Updated by Benjamin Serfhos over 3 years ago

  • File Screenshot 2020-08-13 at 13.54.04.png added

I needed to do this for my customer and thought it would be interesting as well, i added this through forge so it could be in the core eventually.

I don't think this would be eligible for backporting to v9 as its a new feature and features normally don't get backported. I think the project lead is the person that makes this decision.

I still need to create the changelog but will do that today too, so this could be reviewed by the responsible endbosses :-)

ps. I added a screenshot of how i currently implemented it in the code.

Actions
Copy link
 #7

Updated by Benjamin Serfhos over 3 years ago

I will refactor the display to show the sorting in the tables.

Actions
Copy link
 #8

Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

Actions
Copy link
 #9

Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

Actions
Copy link
 #10

Updated by Benjamin Serfhos over 3 years ago

  • % Done changed from 0 to 100

So, i updated the patch and is available for reviewers. The columns labels are now clickable (like the list view). I also added documentation for this feature change and it seems like this feature is done. Let's wait for reviewers to have their feedback on this implementation :-)

Actions
Copy link
 #11

Updated by Benjamin Serfhos over 3 years ago

Stefan P, I don't know if you are on slack but i ported the change in my environment using a patch.

Im using this file in combination with composer package "cweagans/composer-patches".

and the added patch in the build with; 

    "extra": {
        "patches": {
            "typo3/cms-redirects": {
                "https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317": "build/patches/redirects-ordering.patch" 
            }
        }
    }

Hope you can use this for your environment.

Actions
Copy link
 #12

Updated by Benjamin Serfhos over 3 years ago

  • File deleted (Screenshot 2020-08-13 at 13.54.04.png)
Actions
Copy link
 #13

Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

Actions
Copy link
 #14

Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

Actions
Copy link
 #15

Updated by Gerrit Code Review over 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

Actions
Copy link
 #16

Updated by Gerrit Code Review over 3 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

Actions
Copy link
 #17

Updated by Gerrit Code Review over 3 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

Actions
Copy link
 #18

Updated by Gerrit Code Review over 3 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

Actions
Copy link
 #19

Updated by Gerrit Code Review over 3 years ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

Actions
Copy link
 #20

Updated by Anonymous over 3 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #21

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF