Feature #91890

Make the list in the redirects module sortable

Added by Stefan P 3 months ago. Updated 29 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2020-07-29
Due date:
% Done:

100%

PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

It would be nice if one could sort the redirects in teh module, especially by hit count and last hit (for example to easily find "dead" redirects that can be deleted).

redirects-ordering.patch View - Patch file for TYPO3 9.5.20 (6.62 KB) Benjamin Serfhos, 2020-08-14 14:37

Associated revisions

Revision d268ac90 (diff)
Added by Benjamin Serfhos 29 days ago

[FEATURE] Allow ordering of displayed columns in redirects overview

Releases: master
Resolves: #91890
Change-Id: I64d7a355ca4e88b4f73c4cb46fce60ca7b0605c6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317
Tested-by: Daniel Goerz <>
Tested-by: Oliver Bartsch <>
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Daniel Goerz <>
Reviewed-by: Oliver Bartsch <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Stefan P 3 months ago

It is possible to achive this slightly in the list module on the root (0), but without the nice interface and the filtering. But this can only be done by admins, not by editors, anyways.

#2 Updated by Gerrit Code Review 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

#3 Updated by Stefan P 2 months ago

Any chance that gets ported back to v9?

#4 Updated by Gerrit Code Review 2 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

#5 Updated by Gerrit Code Review 2 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

#6 Updated by Benjamin Serfhos 2 months ago

  • File Screenshot 2020-08-13 at 13.54.04.png added

I needed to do this for my customer and thought it would be interesting as well, i added this through forge so it could be in the core eventually.

I don't think this would be eligible for backporting to v9 as its a new feature and features normally don't get backported. I think the project lead is the person that makes this decision.

I still need to create the changelog but will do that today too, so this could be reviewed by the responsible endbosses :-)

ps. I added a screenshot of how i currently implemented it in the code.

#7 Updated by Benjamin Serfhos 2 months ago

I will refactor the display to show the sorting in the tables.

#8 Updated by Gerrit Code Review 2 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

#9 Updated by Gerrit Code Review 2 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

#10 Updated by Benjamin Serfhos 2 months ago

  • % Done changed from 0 to 100

So, i updated the patch and is available for reviewers. The columns labels are now clickable (like the list view). I also added documentation for this feature change and it seems like this feature is done. Let's wait for reviewers to have their feedback on this implementation :-)

#11 Updated by Benjamin Serfhos 2 months ago

Stefan P, I don't know if you are on slack but i ported the change in my environment using a patch.

Im using this file in combination with composer package "cweagans/composer-patches".

and the added patch in the build with;

    "extra": {
        "patches": {
            "typo3/cms-redirects": {
                "https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317": "build/patches/redirects-ordering.patch" 
            }
        }
    }

Hope you can use this for your environment.

#12 Updated by Benjamin Serfhos 2 months ago

  • File deleted (Screenshot 2020-08-13 at 13.54.04.png)

#13 Updated by Gerrit Code Review 2 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

#14 Updated by Gerrit Code Review 2 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

#15 Updated by Gerrit Code Review about 1 month ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

#16 Updated by Gerrit Code Review about 1 month ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

#17 Updated by Gerrit Code Review about 1 month ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

#18 Updated by Gerrit Code Review about 1 month ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

#19 Updated by Gerrit Code Review 29 days ago

Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317

#20 Updated by Anonymous 29 days ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF