Bug #91905

Functional tests on translation handling miss their translated page

Added by Anja Leichsenring 3 months ago. Updated 21 days ago.

Status:
Closed
Priority:
Should have
Category:
Tests
Target version:
-
Start date:
2020-07-30
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If the test setup does not provide a translated page, but requests the frontend in a language different from default, the response will only contain default language records.
If the test assertions only test for fallen back records or records not being in the response, the assertion will succeed, but the test itself is wrong.

Associated revisions

Revision d5827e4f (diff)
Added by Anja Leichsenring 3 months ago

[BUGFIX] Tests for translated content will prepare a translated page

Language handling always bases on the existence of a page version for
the requested language. If this is not available, handling follows
fallback settings.

Functional Tests that test for translated content to be returned
as expected must provide such a translated page on their own, else
the fallback handling kicks in, renders the test falsly reassuring.

Resolves: #91905
Releases: master, 10.4, 9.5
Change-Id: I77d1e096cd0e62134ffd818f8bd32667e566d44a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65146
Tested-by: TYPO3com <>
Tested-by: Christian Kuhn <>
Tested-by: Benni Mack <>
Reviewed-by: Christian Kuhn <>
Reviewed-by: Benni Mack <>

Revision 7de0298f (diff)
Added by Anja Leichsenring 3 months ago

[BUGFIX] Tests for translated content will prepare a translated page

Language handling always bases on the existence of a page version for
the requested language. If this is not available, handling follows
fallback settings.

Functional Tests that test for translated content to be returned
as expected must provide such a translated page on their own, else
the fallback handling kicks in, renders the test falsly reassuring.

Resolves: #91905
Releases: master, 10.4, 9.5
Change-Id: I77d1e096cd0e62134ffd818f8bd32667e566d44a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65157
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

Revision dbc2af34 (diff)
Added by Anja Leichsenring 3 months ago

[BUGFIX] Tests for translated content will prepare a translated page

Language handling always bases on the existence of a page version for
the requested language. If this is not available, handling follows
fallback settings.

Functional Tests that test for translated content to be returned
as expected must provide such a translated page on their own, else
the fallback handling kicks in, renders the test falsly reassuring.

Resolves: #91905
Releases: master, 10.4, 9.5
Change-Id: I77d1e096cd0e62134ffd818f8bd32667e566d44a
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65173
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65146

#2 Updated by Gerrit Code Review 3 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65146

#3 Updated by Gerrit Code Review 3 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65146

#4 Updated by Gerrit Code Review 3 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65146

#5 Updated by Gerrit Code Review 3 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65146

#6 Updated by Gerrit Code Review 3 months ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65157

#7 Updated by Gerrit Code Review 3 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65173

#8 Updated by Anja Leichsenring 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#9 Updated by Benni Mack 21 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF