Bug #92052
closed
Wrong return hint for TYPO3\CMS\Core\Domain\Repository\PageRepository::getRecordOverlay
100%
Description
The return hint in the doc block states that it would return FALSE when there is no translation and the OLmode is set to "hideNonTranslated".
The method is setting the row to NULL in those cases, thus not respecting the hint and misleading developers into assuming the wrong return values.
I think we should be clearer here, to avoid developers from checking for === FALSE or something similar, and mention the NULL instead of FALSE.
Updated by Gerrit Code Review over 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65392
Updated by Gerrit Code Review over 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65392
Updated by Gerrit Code Review over 4 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65417
Updated by Anonymous over 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 02778ae158847c1a7b182982e13b8fbc67d80219.
Updated by