Project

General

Profile

Actions
Copy link

Bug #92052

closed

Wrong return hint for TYPO3\CMS\Core\Domain\Repository\PageRepository::getRecordOverlay

Added by Kevin Ditscheid over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2020-08-20
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The return hint in the doc block states that it would return FALSE when there is no translation and the OLmode is set to "hideNonTranslated".
The method is setting the row to NULL in those cases, thus not respecting the hint and misleading developers into assuming the wrong return values.
I think we should be clearer here, to avoid developers from checking for === FALSE or something similar, and mention the NULL instead of FALSE.

Actions
Copy link

Also available in: Atom PDF