Feature #92231

Add some more error messages to linkvalidator

Added by Sybille Peters 3 months ago. Updated 9 days ago.

Status:
Under Review
Priority:
Should have
Category:
Linkvalidator
Target version:
-
Start date:
2020-09-08
Due date:
% Done:

0%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

For some error types, the error messages are too long, verbose and not suited for non technical audience.

The reason is, that not all error types have language strings and in some cases a generic error message and the exception (from Guzzle) is used.

I would propose to add some more error messages.

Also, the "Network error / invalid domain" error message is misleading, because all error reasons listed in https://curl.haxx.se/libcurl/c/libcurl-errors.html return that. In fact, the error code is also returned which could be used to give a more specific error message.

Examples that already have short custom error messages:

404:

The requested url was not found (404).

403:

Accessing this address is not allowed (403).

Examples for errors with long and cluttered error message

401:

An error occurred (401): "Client error: `GET https://url-which-requires-login/login` resulted in a `401 Unauthorized` response:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xh (truncated...)
".

wrong domain:

Network error / invalid domain:cURL error 6: Could not resolve host: invalid-domain.de; Unknown error (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)

ssl problem:

Network error / invalid domain:cURL error 51: Unable to communicate securely with peer: requested domain name does not match the server's certificate. (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)

timeout:

Network error / invalid domain:cURL error 28: Connection timed out after 10001 milliseconds (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)

HTTP Status code 500:

Network error / invalid domain:Server error: `GET http://some-domain/` resulted in a `500 Internal Server Error` response:
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>500 Internal Server Error</title>
</head><body>
< (truncated...)

wrong protocol:

Network error / invalid domain:cURL error 1: Protocol hhttps not supported or disabled in libcurl (see https://curl.haxx.se/libcurl/c/libcurl-errors.html)

502:

Network error / invalid domain:Server error: `GET http://hochschule-ohne-grenzen.org/` resulted in a `502 Proxy Error` response:
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>502 Proxy Error</title>
</head><body>
<h1>Proxy E (truncated...)
07.09.20 16:15

Files

linkvalidator.png (175 KB) linkvalidator.png Sybille Peters, 2020-09-11 10:46
#1

Updated by Sybille Peters 3 months ago

  • Description updated (diff)
#2

Updated by Sybille Peters 3 months ago

I am adding some more example screenshots to illustrate the problem - because after these links are fixed, I won't have them anymore :)

In German:

#3

Updated by Gerrit Code Review about 2 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66074

#4

Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66074

#5

Updated by Gerrit Code Review about 1 month ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66074

#6

Updated by Gerrit Code Review about 1 month ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66074

#7

Updated by Gerrit Code Review about 1 month ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66074

#8

Updated by Gerrit Code Review 29 days ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66074

#9

Updated by Gerrit Code Review 29 days ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66074

#10

Updated by Gerrit Code Review 29 days ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66074

#11

Updated by Gerrit Code Review 24 days ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66074

#12

Updated by Gerrit Code Review 9 days ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66074

#13

Updated by Gerrit Code Review 9 days ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66074

Also available in: Atom PDF