Bug #92304

Missing translation language option in EmailToSender

Added by Oliver Bartsch 12 days ago. Updated 4 days ago.

Status:
Resolved
Priority:
Must have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2020-09-14
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The EmailToSender finisher is missing the "translation.language" field. As the translation language can't be adjusted and TranslationService is a singleton, the language defined in EmailToReceiver (if defined before EmailToSender) is also used for EmailToSender without any possibility to override this.

This option is however already documented here: https://docs.typo3.org/c/typo3/cms-form/10.4/en-us/I/Config/proto/finishersDefinition/finishers/EmailToSender.html?highlight=language#options-translation-language

Associated revisions

Revision fd84ba26 (diff)
Added by Oliver Bartsch 4 days ago

[BUGFIX] Add missing language option to EmailToSender

The EmailFinisher class evaluates the defined "translation language"
which can be used to define the language of the mail content
independent of the current frontend language. The corresponding
option is however missing in the EmailToSender configuration.

This leads to side effects if e.g. EmailToReceiver is configured with
this option before EmailToSender. The EmailToSender finisher then
automatically also uses this language without any possibility to
prevent this behaviour.

Therefore the missing configuration option for defining a
translation language is now also available in the EmailToSender
finisher configuration like already claimed in the documentation.

Resolves: #92304
Releases: master, 10.4
Change-Id: Id81a5f616d439b4e4e844e270cadde3888ace46d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65733
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Tested-by: Georg Ringer <>
Reviewed-by: Benni Mack <>
Reviewed-by: Georg Ringer <>

Revision e77b87a5 (diff)
Added by Oliver Bartsch 4 days ago

[BUGFIX] Add missing language option to EmailToSender

The EmailFinisher class evaluates the defined "translation language"
which can be used to define the language of the mail content
independent of the current frontend language. The corresponding
option is however missing in the EmailToSender configuration.

This leads to side effects if e.g. EmailToReceiver is configured with
this option before EmailToSender. The EmailToSender finisher then
automatically also uses this language without any possibility to
prevent this behaviour.

Therefore the missing configuration option for defining a
translation language is now also available in the EmailToSender
finisher configuration like already claimed in the documentation.

Resolves: #92304
Releases: master, 10.4
Change-Id: Id81a5f616d439b4e4e844e270cadde3888ace46d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65802
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Reviewed-by: Georg Ringer <>

History

#1 Updated by Gerrit Code Review 12 days ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65733

#2 Updated by Oliver Bartsch 4 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Gerrit Code Review 4 days ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/65802

#4 Updated by Oliver Bartsch 4 days ago

  • Status changed from Under Review to Resolved

Also available in: Atom PDF