Project

General

Profile

Actions

Bug #92517

closed

No alternative namespace supported by ExtbasePluginEnhancer

Added by Daniel Siepmann over 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
Extbase
Start date:
2020-10-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

It is possible to configure an alternative pluginNamespace for an Extbase Plugin.
This can be done via TypoScript:

plugin {
    tx_extname_pluginname {
        view {
            pluginNamespace = search
        }
    }
}

As this is not supported by the ExtbasePluginEnhancer, those can not be combined. It is not possible to provide routing configuration when using a custom configured pluginNamespace.

I would suggest to respect the "namespace" option, which is respected by PluginEnhancer, which is extended by ExtbasePluginEnhancer. This way integrator are able to configure an alternative namespace in both places.

Our use case: Map only some parts of routes, but keep others, e.g. search parameters. Those should not add unnecessary garbage to url like "tx_extname_pluginname" but "search" instead.

The option was initially introduced to access the arguments from another plugin (as far as I know).

Steps to reproduce:

Use any existing Extbase Plugin (which is using arguments) and insert it into a page. Configure an alternative pluginNamespace as shown above. The arguments should no longer be mapped. Add "namespace" with same value to the configuration of the Enhaner, it should work with the patch.

In case one follows this approach, one can omit the extension and plugin option of the Enhancer. Those are only used to generate the namespace.

Actions #1

Updated by Daniel Siepmann over 3 years ago

  • Description updated (diff)
Actions #2

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66083

Actions #3

Updated by Daniel Siepmann over 3 years ago

  • Description updated (diff)
Actions #5

Updated by Daniel Siepmann over 3 years ago

  • Status changed from Under Review to Rejected
Actions #6

Updated by Gerrit Code Review over 3 years ago

  • Status changed from Rejected to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66083

Actions #7

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66083

Actions #8

Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66083

Actions #9

Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66083

Actions #10

Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66083

Actions #11

Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66083

Actions #12

Updated by Gerrit Code Review over 1 year ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66083

Actions #13

Updated by Gerrit Code Review over 1 year ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66083

Actions #14

Updated by Daniel Siepmann over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #15

Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF