Bug #92758
closedIncorrect fallback of previewRenderer when using fluidBasedPageModule
100%
Description
How to reproduce¶
1. Use a v10 TYPO3
2. Enable fluidBasedPageModule as feature
3. Add a custom preview renderer with $GLOBALS['TCA']['tt_content']['types']['list']['previewRenderer']['extension_plugin'] = \Vendor\Extension\Backend\Preview\PreviewRenderer::class;
4. Install extension using plugins by default, in my case sf_event_mgt
5. Create a page with a plugin of the default extension
Error¶
Loading the page in page module in backend throws an exception with "Class Array must implement PreviewRendererInterface".
When debugging the method "resolveRendererFor" in class \TYPO3\CMS\Backend\Preview\StandardPreviewRendererResolver, it gives me an array (with my custom preview renderer class inside) when trying to load the PreviewRenderer for the default extension plugin.
Solution¶
From line 61 on the class want to provide a fallback if there is no custom PreviewRenderer as there is no one for the default extension. But the fallback gives me an array instead of the class name.
For the fallback there should be used $tcaTypeField['previewRenderer']
instead of $typeConfiguration['previewRenderer']
.
Updated by Gerrit Code Review about 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66413
Updated by Gerrit Code Review about 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66413
Updated by Gerrit Code Review about 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66413
Updated by Gerrit Code Review about 4 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66413
Updated by Gerrit Code Review about 4 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66413
Updated by Gerrit Code Review almost 4 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/66413
Updated by Gerrit Code Review almost 4 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67474
Updated by Thomas Löffler almost 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 05e679a71379b0a7f16143f09587ffe1c4e0c3e0.
Updated by Gerrit Code Review almost 4 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67474
Updated by Thomas Löffler almost 4 years ago
- Status changed from Under Review to Resolved
Applied in changeset ac3d49ea3566f9c9e520935425522bcbf9e1e0fd.