Bug #93207
closedDuplicate error message in AjaxDataHandler.ts
100%
Description
I noticed that handleErrors is called twice in Build/Sources/TypeScript/backend/Resources/Public/TypeScript/AjaxDataHandler.ts.
Once in AjaxDataHandler->initialize and again in AjaxDataHandler->process.
One of both should be removed. I believe removing the one in initialize makes more sense as the one in process will also get called when deleting a record.
How to reproduce:
Put these lines in \TYPO3\CMS\Backend\Controller\SimpleDataHandlerController::processAjaxRequest after "$this->tce->printLogErrorMessages();" to force an error flash message:
$flashMessageService->getMessageQueueByIdentifier()->addMessage(GeneralUtility::makeInstance(
\TYPO3\CMS\Core\Messaging\FlashMessage::class,
'Duplicate error message!',
'Duplicate error message title',
\TYPO3\CMS\Core\Messaging\FlashMessage::ERROR
));
Updated by Gerrit Code Review almost 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67331
Updated by Simon Schaufelberger almost 4 years ago
- Related to Task #92199: Streamline AjaxDataHandler added
Updated by Gerrit Code Review almost 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67331
Updated by Gerrit Code Review almost 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67331
Updated by Gerrit Code Review almost 4 years ago
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67397
Updated by Anonymous almost 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 9eada3ad40bb3666f1da4c31cb15d829b36f64e9.