Bug #93207

Duplicate error message in AjaxDataHandler.ts

Added by Simon Schaufelberger 6 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2021-01-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

I noticed that handleErrors is called twice in Build/Sources/TypeScript/backend/Resources/Public/TypeScript/AjaxDataHandler.ts.

Once in AjaxDataHandler->initialize and again in AjaxDataHandler->process.

One of both should be removed. I believe removing the one in initialize makes more sense as the one in process will also get called when deleting a record.

How to reproduce:

Put these lines in \TYPO3\CMS\Backend\Controller\SimpleDataHandlerController::processAjaxRequest after "$this->tce->printLogErrorMessages();" to force an error flash message:

 $flashMessageService->getMessageQueueByIdentifier()->addMessage(GeneralUtility::makeInstance(
            \TYPO3\CMS\Core\Messaging\FlashMessage::class,
            'Duplicate error message!',
            'Duplicate error message title',
            \TYPO3\CMS\Core\Messaging\FlashMessage::ERROR
        ));

Related issues

Related to TYPO3 Core - Task #92199: Streamline AjaxDataHandlerUnder Review2020-09-04

Actions
#1

Updated by Simon Schaufelberger 6 months ago

  • Description updated (diff)
#2

Updated by Gerrit Code Review 6 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67331

#3

Updated by Simon Schaufelberger 6 months ago

  • Description updated (diff)
#4

Updated by Simon Schaufelberger 6 months ago

  • Related to Task #92199: Streamline AjaxDataHandler added
#5

Updated by Gerrit Code Review 6 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67331

#6

Updated by Gerrit Code Review 5 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67331

#7

Updated by Gerrit Code Review 5 months ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67397

#8

Updated by Anonymous 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Benni Mack 4 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF