Feature #93330
closedImprove record history view
100%
Description
Given:
- a page with a "Text" element
- insert a table into the bodytext field (CKEditor)
<table class="table table-bordered table-hover"> <thead> <tr> <th>#</th> <th>FirstName</th> <th>LastName</th> <th>Username</th> </tr> </thead> <tbody> <tr> <td>1</td> <td>John</td> <td>Doe</td> <td>@JohnDoe</td> </tr> </tbody> </table>
- save the content element
- add a new row to the table
<tr> <td>2</td> <td>Jane</td> <td>Doe</td> <td>@JanveDoe</td> </tr>
- save and close the content element
- change to "List" module and open the "History/Undo" view of the content element
Expectation:
- I can see the changes of the bodytext
Actual:
- it is hard to see the changes of the table
- depending on the table content, a long scroll bar needs to be used to see any difference
Suggestion:
- change the CSS for class .diff-item-result
from white-space: pre;
to white-space: pre-wrap;
(or something similar) to keep spacing but allow line breaks
Files
Updated by Nicole Cordes almost 4 years ago
- File 2021-01-20_154219.png 2021-01-20_154219.png added
- File 2021-01-20_154307.png 2021-01-20_154307.png added
Updated by Gerrit Code Review almost 4 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494
Updated by Gerrit Code Review almost 4 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494
Updated by Gerrit Code Review almost 4 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494
Updated by Gerrit Code Review almost 4 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494
Updated by Gerrit Code Review almost 4 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494
Updated by Gerrit Code Review almost 4 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494
Updated by Gerrit Code Review almost 4 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494
Updated by Gerrit Code Review almost 4 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494
Updated by Oliver Hader almost 4 years ago
- File 93330_ins_styles.png 93330_ins_styles.png added
Remark on https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494/8 (patch-set 8) - having display: inline-block
disabled
Updated by Gerrit Code Review almost 4 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494
Updated by Benni Mack almost 4 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 7f488e0e8057611a787dbe31c3266a964560da6f.