Feature #93330

Improve record history view

Added by Nicole Cordes 6 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
Start date:
2021-01-20
Due date:
% Done:

100%

Estimated time:
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Given:
- a page with a "Text" element
- insert a table into the bodytext field (CKEditor)

<table class="table table-bordered table-hover">
    <thead>
        <tr>
            <th>#</th>
            <th>FirstName</th>
            <th>LastName</th>
            <th>Username</th>
        </tr>
    </thead>
    <tbody>
        <tr>
            <td>1</td>
            <td>John</td>
            <td>Doe</td>
            <td>@JohnDoe</td>
        </tr>
    </tbody>
</table>

- save the content element
- add a new row to the table
        <tr>
            <td>2</td>
            <td>Jane</td>
            <td>Doe</td>
            <td>@JanveDoe</td>
        </tr>

- save and close the content element
- change to "List" module and open the "History/Undo" view of the content element

Expectation:
- I can see the changes of the bodytext

Actual:
- it is hard to see the changes of the table
- depending on the table content, a long scroll bar needs to be used to see any difference

Suggestion:
- change the CSS for class .diff-item-result from white-space: pre; to white-space: pre-wrap; (or something similar) to keep spacing but allow line breaks


Files

2021-01-20_154219.png (26.2 KB) 2021-01-20_154219.png Nicole Cordes, 2021-01-20 14:43
2021-01-20_154307.png (29.7 KB) 2021-01-20_154307.png Nicole Cordes, 2021-01-20 14:43
93330_ins_styles.png (229 KB) 93330_ins_styles.png Oliver Hader, 2021-01-25 11:23
#1

Updated by Nicole Cordes 6 months ago

  • Description updated (diff)
#3

Updated by Gerrit Code Review 6 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494

#4

Updated by Gerrit Code Review 6 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494

#5

Updated by Gerrit Code Review 6 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494

#6

Updated by Gerrit Code Review 6 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494

#7

Updated by Gerrit Code Review 6 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494

#8

Updated by Gerrit Code Review 6 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494

#9

Updated by Gerrit Code Review 6 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494

#10

Updated by Gerrit Code Review 6 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494

#11

Updated by Oliver Hader 6 months ago

Remark on https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494/8 (patch-set 8) - having display: inline-block disabled

#12

Updated by Gerrit Code Review 6 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494

#13

Updated by Benni Mack 6 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#14

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF