Project

General

Profile

Actions

Bug #93351

closed

Paginator does not prevent invalid current page values and displays empty view

Added by Oliver Bartsch almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Category:
Miscellaneous
Target version:
-
Start date:
2021-01-22
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

There are multiple possibilities how an invalid current page number can be passed to the paginator.
For example if the view provides a "jump to page" feature where no limit is set or the limit changed in the background (e.g. some other user removed records in the meantime).
Such case should not lead to empty results but should silently be resolved by the paginator.

Actions #1

Updated by Oliver Bartsch almost 4 years ago

Speaking only about a current page value exceeding the maximum number of pages. If lower, this can not be unintentionally and an exception is already thrown in this case.

Actions #2

Updated by Gerrit Code Review almost 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67509

Actions #3

Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67509

Actions #4

Updated by Gerrit Code Review almost 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67509

Actions #5

Updated by Gerrit Code Review almost 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67509

Actions #6

Updated by Gerrit Code Review almost 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67509

Actions #7

Updated by Oliver Bartsch almost 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Gerrit Code Review almost 4 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67712

Actions #9

Updated by Oliver Bartsch almost 4 years ago

  • Status changed from Under Review to Resolved
Actions #10

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF