Project

General

Profile

Actions

Task #93379

closed

Improve exceptions when BE.adminOnly or BE.IPmaskList is used

Added by Torben Hansen almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2021-01-28
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

When a TYPO3 administrator configures either [BE][adminOnly] > 0 or [BE][adminOnly] = -1, the LockedBackendGuard throws an exception. This exception is only shown to the user, when TYPO3 in configured to DEBUG mode. When TYPO3 is in LIVE mode, only "Oops, an error occurred!" is shown to the user. Also, the HTTP response status for this configuration is 500, which is wrong, since access to the backend is denied and thus a 403 status code should be sent.

When a TYPO3 administrator configures [BE][IPmaskList] to a valid IP Mask, the LockedBackendGuard also throws an exception when the current IP address does not match the configured pattern. Again, a 500 HTTP response status is sent by TYPO3 and only a "Oops, an error occurred!" message shown to the user, when TYPO3 is in LIVE mode.

Both scenarios should show the messages thrown by the exceptions in LockedBackendGuard and also the HTTP response code should be 403 instead of 500.

Actions #1

Updated by Gerrit Code Review almost 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67546

Actions #2

Updated by Gerrit Code Review almost 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67546

Actions #3

Updated by Gerrit Code Review almost 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67546

Actions #4

Updated by Gerrit Code Review almost 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67546

Actions #5

Updated by Gerrit Code Review almost 4 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67546

Actions #6

Updated by Gerrit Code Review almost 4 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67595

Actions #7

Updated by Torben Hansen almost 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack over 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF