Bug #93422

Flash messages used for callouts in page module

Added by Sybille Peters 3 months ago. Updated 3 months ago.

Status:
Needs Feedback
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2021-02-03
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Some errors / warnings are handled in PageLayoutController

These use a " callout " message type with the InfoBox template:

<f:be.infobox title="{title}" state="{state}">
<f:format.raw>{message}</f:format.raw>
</f:be.infobox>

which results for example in:

<div class="callout callout-danger"><div class="media"><div class="media-left"><span class="fa-stack fa-lg callout-icon"><i class="fa fa-circle fa-stack-2x"></i><i class="fa fa-times fa-stack-1x"></i></span></div><div class="media-body"><h4 class="callout-title">shortcut with missing target</h4><div class="callout-body">
    Page is configured to be a link but there is actually no valid target defined.
</div></div></div></div>


Other messages (for example "Unused elements detected on this page") use a flashmessage styling:

<div class="typo3-messages"><div class="alert alert-warning">  <div class="media">    <div class="media-left">      <span class="fa-stack fa-lg">        <i class="fa fa-circle fa-stack-2x"></i>        <i class="fa fa-exclamation fa-stack-1x"></i>      </span>    </div>    <div class="media-body">      <h4 class="alert-title">Unused elements detected on this page</h4>      <p class="alert-message">These elements don't belong to any of the available columns of this page. You should either delete them or move them to existing columns. We highlighted the problematic records for you.</p>    </div>  </div></div></div>


IMHO, the same styling (for callouts) should be used in these cases as well.


Files

message_shortcut_missing_target.png (9.41 KB) message_shortcut_missing_target.png Sybille Peters, 2021-02-03 16:26
message_unused_elements.png (11 KB) message_unused_elements.png Sybille Peters, 2021-02-03 16:27

Related issues

Related to TYPO3 Core - Feature #93192: Add event to add additional callouts in page moduleClosedSybille Peters2020-12-31

Actions
Related to TYPO3 Core - Task #93428: Rename function getHeaderFlashMessagesForCurrentPid() in PageLayoutController to reflect that callouts are used and not flashmesseagesNew2021-02-04

Actions
#1

Updated by Sybille Peters 3 months ago

  • Related to Feature #93192: Add event to add additional callouts in page module added
#2

Updated by Georg Ringer 3 months ago

  • Status changed from New to Needs Feedback

please don't mix flash messages with callouts! those are different on purpose!

- flash messages: those are normally shown after an action, e.g saving something was succesful
- callouts: give the user permanent feedback

So in the given example the flash mssage could be changed to a callout but please discuss that with the ux group

#3

Updated by Sybille Peters 3 months ago

  • Subject changed from Different styles used for Flash messages in page module to Flash messages used for callouts in page module
  • Description updated (diff)
#4

Updated by Sybille Peters 3 months ago

Thanks for clearing that up. Wasn't aware of the "callouts".

I updated title and description.

Not sure which "ux group" I should discuss this with.

#5

Updated by Sybille Peters 3 months ago

  • Related to Task #93428: Rename function getHeaderFlashMessagesForCurrentPid() in PageLayoutController to reflect that callouts are used and not flashmesseages added

Also available in: Atom PDF