Bug #93511

open

Assets from f:asset VH do not get concatenated

Added by Roman Büchler almost 4 years ago. Updated 6 months ago.

Status:

New

Priority:

Should have

Assignee:

Category:

Frontend

Target version:

Start date:

2021-02-14

Due date:

% Done:

Estimated time:

TYPO3 Version:

PHP Version:

7.4

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Assets from the f:asset view helpers don't get concatenated with assets from TS. The following setup results in four tags:

Setup¶

TS¶

config.concatenateCss = 1
config.concatenateJs = 1
page.includeCSS.theme = EXT:pizpalue/Resources/Public/Scss/theme-main.scss
page.includeJSFooterlibs.pizpalueGeneral = EXT:pizpalue/Resources/Public/JavaScript/Src/jquery.general.js

Fluid¶

<f:asset.css identifier="ppAos" href="EXT:pizpalue/Resources/Public/Contrib/aos/aos.css" media="all" />
<f:asset.script identifier="ppAos" src="EXT:pizpalue/Resources/Public/Contrib/aos/aos.js" />

Resulting tags¶

<link rel="stylesheet" type="text/css" href="/typo3temp/assets/compressed/merged-88a99c8e8d704ebf6ad1e0afe44e4233.css?1613296105" media="all">
<link media="all" href="/typo3conf/ext/pizpalue/Resources/Public/Contrib/aos/aos.css?1600502411" rel="stylesheet" type="text/css" >
...
<script src="/typo3temp/assets/compressed/merged-3b027b1d7f1ff7962dd04ef5ab41b576.js?1613296210" type=""></script>
<script src="/typo3conf/ext/pizpalue/Resources/Public/Contrib/aos/aos.js?1600502411"></script>

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Roman Büchler almost 4 years ago

Subject changed from Asset VH do not get concatenated to Assets from f:asset VH do not get concatenated

Actions

Copy link

Updated by Roman Büchler almost 3 years ago

Related to Bug #91312: CSS/JS added via AssetCollector does not respect compression and concatenation added

Actions

Copy link

Updated by Roman Büchler almost 3 years ago

According to the API description (https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/Assets/Index.html) concatenation isn't needed due to the use of link header (http/2):

The AssetCollector helps to work with content elements as components, effectively reducing the CSS to be loaded. It leverages making use of HTTP/2 which removes the necessity to have all files concatenated into one file.

But without using the extension http2 (https://github.com/b13/http2) the link header isn't sent.

Actions

Copy link