Project

General

Profile

Actions

Bug #93521

open

Available cookies from previous request are lost, after being redirected to an error page by the PageContentErrorHandler

Added by Kevin von Spiczak about 3 years ago. Updated over 1 year ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2021-02-16
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
10
PHP Version:
7.3
Tags:
pending-close
Complexity:
Is Regression:
Sprint Focus:

Description

We noticed that our frontend users were not logged in anymore, when reaching e.g. a 404 page.
In our SiteConfiguration we defined a couple errorHandler's of type "Show Content from Page [Page]", which is the PageContentErrorHandler.
We use this for:
  • 404
  • 403
  • 401
  • 500
  • 503

I managed to fix this by passing the cookies from the previous request with the CookieJar class from Guzzle. I attached the patch that we use in our codebase as .diff file.


Files

keepAvailableCookiesInPageContentErrorHandlerRequest.diff (1.31 KB) keepAvailableCookiesInPageContentErrorHandlerRequest.diff keepAvailableCookiesInPageContentErrorHandlerRequest.diff Kevin von Spiczak, 2021-02-16 12:55
Actions #1

Updated by Georg Ringer about 3 years ago

  • Status changed from New to Accepted
  • Assignee set to Georg Ringer
Actions #2

Updated by Gerrit Code Review about 3 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67958

Actions #3

Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67958

Actions #4

Updated by Gerrit Code Review about 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/67958

Actions #5

Updated by Georg Ringer over 2 years ago

  • Status changed from Under Review to New
Actions #6

Updated by Georg Ringer almost 2 years ago

  • Assignee deleted (Georg Ringer)
Actions #7

Updated by Oliver Hader over 1 year ago

  • Tags set to pending-close

Change-set has been abandoned by author...

Actions #8

Updated by Kevin von Spiczak over 1 year ago

I just came back to this issue, since the latest changes (11.5.20) in the PageContentErrorHandler broke my patch.
First I wanted to fix my patch, but then I noticed it is not needed anymore apparently. My fe_user cookie for instance is not lost anymore, when I reach a 404 page. Before I would login -> force a 404 page and on that page I could see in the navigation menu, that my account module is showing the "logged in state", but the "logged out state".

Maybe someone else can verify this on their end too, then we can close this issue.

Actions

Also available in: Atom PDF