Task #93738
closedgetSearchWords-Hook has different registration-name and function to call
0%
Description
-- new issue created from https://forge.typo3.org/issues/75845#note-1 by Robert Vock--
It is also not possible to use the hook in getSearchWords correctly.
The hook expects a function 'getSearchWords' in the hook object, but calls 'getSearchWords_splitSWords'. To use the hook, you need a class, which has both methods. The first will never be called, but SearchController->hookRequest checks for it's existence:
https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/indexed_search/Classes/Controller/SearchController.php#L907
The problem is here, that the hook is only valid, if function name "getSearchWords" exists in hook-class. But when calling the hook, the function "getSearchWords_splitSWords" is being called.
In any other places, the registration name and the called method name are equal.
The bugfix is a breaking change, because all people, who use this hook have to change the hook-registration in ext_localconf.
Updated by Gerrit Code Review over 3 years ago
- Status changed from New to Under Review
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68370
Updated by Tina Westner over 3 years ago
- Related to Bug #75845: getSearchWords does not work with sentences added
Updated by Gerrit Code Review over 3 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68370
Updated by Benni Mack over 3 years ago
- Target version changed from 11.3 to Candidate for Major Version
Updated by Christian Kuhn about 3 years ago
- Status changed from Under Review to Rejected
Issue is valid but patch was rejected: Let's move to psr-14 event dispatching in v12 instead and just keep that detail bug until then.