Bug #93790: Several tooltips not showing since Bootstap 5 integration - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #93790

closed

Several tooltips not showing since Bootstap 5 integration

Added by Torben Hansen over 3 years ago. Updated about 3 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Target version:

Candidate for Major Version

Start date:

2021-03-21

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Since the integration of Bootstrap 5, several tooltips do not show up any more, as Bootstrap 5 either requires a title or a data-bs-title attribute on the HTML element (see https://getbootstrap.com/docs/5.0/components/tooltips/#options)

One example is BackendUtility::getRecordToolTip(), where previously a data-title attribute was responsible for the tooltip content. The data-title attribute must be changed to data-bs-title.

Actions

Copy link

Updated by Gerrit Code Review over 3 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68553

Actions

Copy link

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68553

Actions

Copy link

Updated by Torben Hansen over 3 years ago

Well, this is not as easy as I thought. When data-bs-title is provided but an empty string, the Bootstrap tooltip component wont initialize and throws a JavaScript error (see https://core.b13.com/typo3-core/typo3.cms/-/jobs/122177). Obviously this does only occur, when data-bs-title is empty, but not when the title attribute is empty. So maybe we switch to use the title attribute where possible.

Actions

Copy link

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68553

Actions

Copy link

Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/68553

Actions

Copy link