Bug #93951: QueryBuilder not yet compatible with doctrine/dbal 2.13.x - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #93951

closed

QueryBuilder not yet compatible with doctrine/dbal 2.13.x

Added by Daniel Siepmann about 3 years ago. Updated over 2 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Database API (Doctrine DBAL)

Target version:

Candidate for patchlevel

Start date:

2021-04-20

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

The QueryBuilder still has the following return type hint for execute() method:

@return \Doctrine\DBAL\Driver\Statement|int

This should include the new Result return type, see #93848.
Otherwise, developers can't use the new none deprecated API. It would be reported as none available by static code analysers, even if it's actually used under the hood.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Daniel Siepmann about 3 years ago

Related to Task #93848: Add compatibility with Doctrine DBAL 2.13.x added

Actions

Copy link

Updated by Marco Huber almost 3 years ago

Since I updated from 10.4.14 to 10.4.15 phpstan gives me this error:

Call to method fetchAll() on an unknown class Doctrine\DBAL\ForwardCompatibility\Result.

$databaseConnection = GeneralUtility::makeInstance(ConnectionPool::class)->getConnectionForTable('table');
$databaseConnection->select(['uid', 'number'], 'table')->fetchAll(FetchMode::ASSOCIATIVE);

Could my error have the same reason?

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Status changed from New to Under Review

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70131

Actions

Copy link