Actions
Bug #93951
closed
QueryBuilder not yet compatible with doctrine/dbal 2.13.x
Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Database API (Doctrine DBAL)
Target version:
Start date:
2021-04-20
Due date:
% Done:
100%
Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
Description
The QueryBuilder still has the following return type hint for execute() method:
@return \Doctrine\DBAL\Driver\Statement|int
This should include the new Result return type, see #93848.
Otherwise, developers can't use the new none deprecated API. It would be reported as none available by static code analysers, even if it's actually used under the hood.
Updated by Daniel Siepmann over 3 years ago
- Related to Task #93848: Add compatibility with Doctrine DBAL 2.13.x added
Updated by Marco Huber over 3 years ago
Since I updated from 10.4.14 to 10.4.15 phpstan gives me this error:
Call to method fetchAll() on an unknown class Doctrine\DBAL\ForwardCompatibility\Result.
$databaseConnection = GeneralUtility::makeInstance(ConnectionPool::class)->getConnectionForTable('table');
$databaseConnection->select(['uid', 'number'], 'table')->fetchAll(FetchMode::ASSOCIATIVE);
Could my error have the same reason?
Updated by Gerrit Code Review over 3 years ago
- Status changed from New to Under Review
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70131
Updated by Benni Mack over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 1ab06b38d85c176314dc29ad0926c24689fda6a6.
Actions