Project

General

Profile

Actions

Bug #94219

closed

current modal state handling is bogus

Added by Andreas Kienast over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2021-05-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Our modal implementation has an internal state handling to determine which modal is the current one if multiple modals get rendered. The new "current" modal is determined once a previous modal is closed, this happens on the hidden.bs.modal event. However, this will break the next modal in case modal A gets closed and triggers modal B:

  • if modal A is visible, the stack contains 1 item
  • if modal A gets removed, the stack still contains 1 item as long the modal is not completely destroyed
  • while modal A gets removed, modal B is rendered, which lets the stack contain 2 items now
  • once modal A is removed, the last item is removed from the stack, which represents modal B
Actions #1

Updated by Gerrit Code Review over 3 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69305

Actions #2

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69305

Actions #3

Updated by Andreas Fernandez over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69331

Actions #5

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69331

Actions #6

Updated by Andreas Fernandez over 3 years ago

  • Status changed from Under Review to Resolved
Actions #7

Updated by Benni Mack about 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF