Bug #94305
closed
AbstractDomainObject::getUid() has wrong PHPDOC
100%
Description
The current master, but also earlier TYPO3 versions, have an incorrect PHPDOC for the getUid() method of each persisted Extbase entity.
This is the annotation:
@return int the uid or NULL if none set yet.
For code tools (like Rector), this looks like the method will return integer always. But it may also returns null (for new entities). This may lead to unwanted refactorings.
Espeacially in older TYPO3 version, which have no (correct) return type hinting set. There the PHPDOC is the only truth.
Still, PHPDOC and return type hinting does not match.
Updated by Gerrit Code Review over 3 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69457
Updated by Andreas Fernandez over 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 0caa1ccec3b35cde17abed198bd34eab18c01a75.
Updated by Gerrit Code Review over 3 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69435
Updated by Andreas Fernandez over 3 years ago
- Status changed from Under Review to Resolved
Applied in changeset ef1ea9dc3fc2289be5a53ebf1b4b6b4298ee5a3c.
Updated by