Task #94347
closed
Resolve inconsistency in naming of Site Configuration language attributes and TypoScript naming for accessing language attributes
100%
Description
Since 9LTS (10LTS and master, too) Site Configuration has a language option for defining the flag and the twoLetterIsoCode.
In Site Configuration it is called `flag`: https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/SiteHandling/AddLanguages.html#flag
In TypoScript one can access this via `flagIdentifier`: https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/DataTypes/Properties/GetText.html#sitelanguage
In Site Configuration it is called `iso-639-1`: https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/SiteHandling/AddLanguages.html#iso-639-1
In TypoScript one can access this via `twoLetterIsoCode `: https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/DataTypes/Properties/GetText.html#sitelanguage
As all other attributes seem to be 1:1 the same identifier, this could perhaps be harmonised. Of course this would need a converter/fallback/migration and I can't decide which might make more sense to adapt.
Updated by Benni Mack over 1 year ago
- Status changed from New to Needs Feedback
Hey,
we've finally reduced the whole logic in TYPO3 v12 to only "locale" the "languageId" and the "flag" (which is more like the "iconIdentifier"). Can you recheck if this is now sufficient to close the ticket?
Updated by J. Peter M. Schuler over 1 year ago
- Priority changed from Should have to Won't have this time
- TYPO3 Version changed from 11 to 12
I'm glad for all the improvements and deprecations.
While the problem will go away with 13 for iso-639-1 and twoLetterIsoCode that part can be flagged "closed, won't fix".
The flag vs flagIdentifier inconsistency however is still there.
I know that harmonizing is odd as there needs to be overrides and fallbacks and fully understand it's feasible to close this as nobody came up with enough time for such an unimportant thing in basically two years.
So from my nitpicking perspective: harmonizing that would still be a benefit,
from my dev perspective: yeah let us close this.
For reference the current URLs in the docs:
https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/Functions/Data.html#sitelanguage
https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/SiteHandling/AddLanguages.html#confval-flag
Updated by Benni Mack over 1 year ago
- Status changed from Needs Feedback to Accepted
Hey,
thanks for the quick answer. Perfect, so I will leave this open and hopefully create an alias for flagIdentifier before v12. This would solve all issues in the ticket, right?
Updated by Gerrit Code Review over 1 year ago
- Status changed from Accepted to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78641
Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78641
Updated by Benni Mack over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset febd2ae01566717dfb2d81f53e5b558c22ebeb23.
Updated by Gerrit Code Review over 1 year ago
- Status changed from Resolved to Under Review
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79512
Updated by Benni Mack over 1 year ago
- Status changed from Under Review to Resolved
Applied in changeset d471a55fb18a9887129779245c4e4a404f7387dc.