Bug #94405

Unintentionally behaviour in workspaces module if elements got deselected bevor action

Added by Lukas Speck about 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2021-06-24
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
workspaces
Complexity:
Is Regression:
Sprint Focus:

Description

There is an issue in the workspaces module, where elements are unintentionally published.

Steps:

Various workflow elements are selected by checkbox and then deselected again.
The selected elements are moved to another stage via a stage action (e.g. from Edit > Ready for release).
Subsequently, a selection is made in the same window that differs from the initial selection.
The subsequent step change (e.g. Ready to Publish > Edit) also affects the elements that were not selected at all in the last step
This leads to the fact that in the following, when only one element is selected, many other elements are unintentionally published live.

Found in v9.5

Possible solution

Empty the "markedRecordsForMassAction" array in Backend.js in the method "Backend.renderWorkspaceInfos".

/**
   * Renders fetched workspace informations
   *
   * @param {Object} result
   */
  Backend.renderWorkspaceInfos = function(result) {
    Backend.elements.$tableBody.children().remove();
*Backend.markedRecordsForMassAction = [];*
    Backend.allToggled = false;
    Backend.elements.$chooseStageAction.prop('disabled', true);
    Backend.elements.$chooseSelectionAction.prop('disabled', true);
    Backend.elements.$chooseMassAction.prop('disabled', result.data.length === 0);

    Backend.buildPagination(result.total);
#1

Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70691

#2

Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70691

#3

Updated by Gerrit Code Review 10 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70691

#4

Updated by Gerrit Code Review 10 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70691

#5

Updated by Oliver Bartsch 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#6

Updated by Gerrit Code Review 10 months ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70728

#7

Updated by Oliver Bartsch 10 months ago

  • Status changed from Under Review to Resolved
#8

Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF