Project

General

Profile

Actions

Bug #94420

closed

Changelog AbstactServices, Migration doesn't make sense

Added by Lina Wolf over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2021-06-26
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The Changelog https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/master/Deprecation-94313-ClassAbstractService.html suggests in the "Migration" section:

"Please see `Service Implementation
<https://docs.typo3.org/m/typo3/reference-coreapi/master/en-us/ApiOverview/Services/Developer/ServiceApi.html#service-implementation&gt;`__
for more details about the required methods."

However if you have a look at this URL it states "All service classes must inherit from the base service class \TYPO3\CMS\Core\Service\AbstractService, unless the service type provides a specific base class (authentication services, for example, inherit from \TYPO3\CMS\Core\Authentication\AbstractAuthenticationService instead)."

It doesn't really make sense to replace the usage of the AbstractService by refering to the AbstractService once more.

Actions #1

Updated by Lina Wolf over 3 years ago

My PR to change the documentation of AbstractService would actually remove that page: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/1432

Actions #2

Updated by Oliver Bartsch over 3 years ago

Hi Lina, regarding:

It doesn't really make sense to replace the usage of the AbstractService by refering to the AbstractService once more.

The changelog does not refer to the AbstractService, but to the documentation of the necessary methods.

Please see Service Implementation for more details about the required methods.

That's why the link targets the "Service Implementation" part instead of the introduction. The introduction should be changed indeed.

Actions #3

Updated by Benni Mack about 3 years ago

  • Status changed from New to Closed

Hey Lina,

I will close this issue, as this seems it is solved in the meantime (in my opinion). Feel free to reach out to me if you think this is the wrong decision.

Actions

Also available in: Atom PDF