Bug #94458

Incorrect RST docu for #90956 (GeneralUtility::getUrl replacement)

Added by Henrik Elsner 3 months ago. Updated 13 days ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
Start date:
2021-07-01
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

typo3/sysext/core/Documentation/Changelog/master/Deprecation-90956-AlternativeFetchMethodsAndReportsForGeneralUtilitygetUrl.rst

in here the migration segment shows an incorrect method call

GeneralUtility::makeInstance(RequestFactory::class)->request($url, [$headers => ['accept' => 'application/json']);

is wrong as the method declaration is the following:

request(string $uri, string $method = 'GET', array $options = []): ResponseInterface
#1

Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69682

#2

Updated by Gerrit Code Review 3 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69682

#3

Updated by Henrik Elsner 3 months ago

  • Description updated (diff)
#4

Updated by Henrik Elsner 3 months ago

  • Subject changed from Incorrect RST docu for to Incorrect RST docu for #90956 (GeneralUtility::getUrl replacement)
#5

Updated by Gerrit Code Review 3 months ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69692

#6

Updated by Henrik Elsner 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Benni Mack 13 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF