Bug #94648
closedGifBuilder does not recognize all changes in config when creating Hash
100%
Description
In the Feature #64158 the way hashes are created was changed. Only certain parameters are taken into consideration when trying to figure out if a picture has to be reprocessed or if the cached picture can be loaded.
On line 740 the keys of the setup array are used but not the set values.
array_keys($this->setup)
Some additional parameters like width and offset are considered as well, but when you start to configure encapsulated images, those changes are not considered. This causes the GifBuilder to give back old cached images even when a new processing would be needed.
Example - the offset parameter of the 10 = Image is not gonna be considered:
$imgConf['file.']['format'] = $fileF[1];
$imgConf['file.']['backColor'] = 'transparent';
$imgConf['file.']['10'] = 'IMAGE';
$imgConf['file.']['10.']['file'] = $filePath;
$imgConf['file.']['10.']['file.']['width'] = $settings['width'];
$imgConf['file.']['10.']['offset'] = $settings['left'] . "," . $settings['top'];
I think this should be fixed by changing the line 740 to something like:
json_encode($this->setup),
This will be somewhat slower, but will at least yield the desired result.
Updated by manu zoli over 3 years ago
- Related to Bug #93688: Gifbuilder - Caching Problem - no update of old combined images added
Updated by Simon Schaufelberger over 2 years ago
- Related to Feature #64158: A faster way to generate GIFBUILDER short MD5 hash inside a filename added
Updated by Simon Schaufelberger over 2 years ago
- Related to Bug #97212: GifBuilder renders wrong image from example typoscript in documentation added
Updated by Gerrit Code Review about 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81118
Updated by Gerrit Code Review about 1 year ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81134
Updated by Gerrit Code Review about 1 year ago
Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81134
Updated by Andreas Nedbal about 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 254589efb50a65e6e1fc575ceb8c25ee604111fd.