Project

General

Profile

Actions

Bug #95043

closed

Result, if page has subpages, can have two results but is only cached once

Added by Tina Westner over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Content Rendering
Target version:
Start date:
2021-08-31
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

When creating a menu for each page the isSubMenu($uid) function is called. Is checks, if a page has subpages or not. The result depends on the given configuration for "includeNotInMenu".

But the return value is cached - and for this cache, the includeNotInMenu-setting is not taken into account.

Example: My page has one subpages, it has nav_hide = 1.
  • My first menu is breadcrumb, we include nav_hide-pages. The result: isSubMenu returns true - there is one subpage.
  • My main nav doesn't include nav_hide-pages. The result: is SubMenu should return false (there are no subpages, when nav_hided-pages are not taken into account), but it returns true - the cached value of my first call is returned.
Actions #1

Updated by Tina Westner over 2 years ago

  • Description updated (diff)
Actions #2

Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70828

Actions #3

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70828

Actions #4

Updated by Benni Mack over 2 years ago

  • Target version changed from 11.4 to 11 LTS
Actions #5

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/70828

Actions #6

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71056

Actions #7

Updated by Anonymous over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF